Skip to content

chore: refactor package.json scripts to enterprise standard#29

Merged
tahiry-dev-29 merged 4 commits into
mainfrom
feat/commerce-tests-pr
Jul 23, 2026
Merged

chore: refactor package.json scripts to enterprise standard#29
tahiry-dev-29 merged 4 commits into
mainfrom
feat/commerce-tests-pr

Conversation

@tahiry-dev-29

@tahiry-dev-29 tahiry-dev-29 commented Jul 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Enterprise package.json scripts refactor, vitest coverage, and prettier formatting.

Summary by CodeRabbit

  • Chores

    • Improved automated quality checks, testing, and build workflows.
    • Added more consistent development, validation, formatting, cleanup, and database management commands.
    • Expanded Docker and Prisma workflow support for local and production environments.

  • Documentation

    • Reformatted engineering guidelines for clearer presentation of architecture, TypeScript, design, and verification standards.

@gemini-code-assist

gemini-code-assist Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates package scripts for Bun/Nx workflows, expands database and test commands, configures Bun and DATABASE_URL in CI, and reformats repository guidance without changing its stated rules.

Changes

Runtime, CI, and Repository Guidance

Layer / File(s) Summary
Project command workflows
package.json		 Adds and reorganizes development, build, database, Prisma, test, formatting, validation, cleanup, Docker, and documentation scripts.
CI runtime and database setup
.github/workflows/ci.yml		 Adds Bun setup to quality checks and provides DATABASE_URL to tests and Prisma generation using a secret-or-dummy fallback.
Repository guidance formatting
AGENT.MD		 Reformats architecture, tooling, TypeScript, design-system, and verification guidance while preserving the existing rules.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: a refactor of package.json scripts toward a more standardized structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/commerce-tests-pr
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch feat/commerce-tests-pr

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
.github/workflows/ci.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

package.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot reviewed Jul 23, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 66-70: Apply DATABASE_URL to the “Run Backend & Frontend Tests”
step so bun run test:all receives the same configured or dummy database
connection; ensure the workflow also provisions PostgreSQL or otherwise mocks
Prisma when relying on the dummy fallback.

In `@package.json`:
- Around line 18-20: Update the build:all script used by the CI fallback so it
does not depend on the ignored .env.local file. Reuse the checked-in Prisma
client or otherwise provide CI-safe environment setup before db:generate, then
invoke the existing Nx build target; preserve the current local build behavior
where possible.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b22d0d7a-1105-466f-91f4-5ca254979d47

📥 Commits

Reviewing files that changed from the base of the PR and between 46a4ae4 and 0ae2324.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • AGENT.MD
  • package.json

Comment thread .github/workflows/ci.yml
Comment thread package.json
@tahiry-dev-29
tahiry-dev-29 merged commit ac5a453 into main Jul 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tahiry-dev-29